Add GOOGLE_GENAI_USE_VERTEXAI variable setting to make workflow work #387
Conversation
Signed-off-by: Huan Li <huan@chatie.io>
There was a problem hiding this comment.
Pull Request Overview
This PR adds automatic configuration of the GOOGLE_GENAI_USE_VERTEXAI variable during the Workload Identity Federation setup process. This ensures that workflows using Vertex AI authentication will have the required variable set correctly.
- Adds
GOOGLE_GENAI_USE_VERTEXAIvariable to the automated GitHub variable setup when theghCLI is available
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…manual setup Co-authored-by: huan <1361891+huan@users.noreply.github.com>
Add GOOGLE_GENAI_USE_VERTEXAI to setup script manual instructions
|
@gemini-cli /review |
|
🤖 Hi @MJjainam, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
![gemini-cli[bot]](https://avatars.githubusercontent.com/in/1473539?s=60&v=4){kind=small}
There was a problem hiding this comment.
📋 Review Summary
This Pull Request introduces a necessary fix by adding the GOOGLE_GENAI_USE_VERTEXAI variable to the setup script, which resolves an authentication error. The change is well-contained and directly addresses the reported issue.
🔍 General Feedback
- The inclusion of
echostatements for the newly set variable provides good visibility into the script's actions. - The overall approach aligns with the existing script's structure and conventions.
| echo "" | ||
| echo "🤖 Variable Name: GOOGLE_GENAI_USE_VERTEXAI" | ||
| echo " Variable Value: true" | ||
| echo " (Set to 'true' to use Vertex AI, or use GOOGLE_GENAI_USE_GCA for Code Assist)" |
There was a problem hiding this comment.
🟡 Consider clarifying how to 'use GOOGLE_GENAI_USE_GCA'. The current phrasing might imply setting GOOGLE_GENAI_USE_GCA to true, but it's not explicitly stated as it is for GOOGLE_GENAI_USE_VERTEXAI. Perhaps something like 'or set GOOGLE_GENAI_USE_GCA to 'true' for Code Assist'.
| echo " (Set to 'true' to use Vertex AI, or use GOOGLE_GENAI_USE_GCA for Code Assist)" | |
| echo " (Set to 'true' to use Vertex AI, or set GOOGLE_GENAI_USE_GCA to 'true' for Code Assist)" |
2 participants
Fix the action error:
See: https://github.com/huan/ai-student-assistant/actions/runs/19178287968/job/54828468408#step:5:410
Fix #388
I ran into this issue today at DevFest Workshop Secure GitHub Workflow with Gemini CLI by Tianzi Cai & Rody Davis, Google.